E547 Run codeql from referenced workflow by jjngx · Pull Request #7837 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]

Skip to content

Conversation

jjngx
Copy link
Contributor
@jjngx jjngx commented May 26, 2025

Proposed changes

This PR updates CodeQL workflow. The main workflow is referenced from a different repo.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork
8000

Signed-off-by: Jakub Jarosz <j.jarosz@f5.com>
@jjngx jjngx requested a review from a team as a code owner May 26, 2025 12:45
@github-actions github-actions bot added github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels May 26, 2025
@jjngx jjngx requested review from pdabelf5, javorszky and GirishF5 May 26, 2025 12:46
@javorszky
Copy link
Contributor

Copy link
Contributor
@javorszky javorszky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay

Copy link
Collaborator
@pdabelf5 pdabelf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these steps no longer needed for building the go binary?

      - name: Setup Golang Environment
        uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0
        with:
          go-version-file: go.mod
        if: matrix.language == 'go'

      # Autobuild attempts to build any compiled languages (C/C++, C#, Go, Java, or Swift).
      # If this step fails, then you should remove it and run the build manually (see below)
      - name: Autobuild
        uses: github/codeql-action/autobuild@ff0a06e83cb2de871e5a09832bc6a81e7276941f # v3.28.18

@jjngx
Copy link
Contributor Author
jjngx commented May 27, 2025

Are these steps no longer needed for building the go binary?

      - name: Setup Golang Environment
        uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0
        with:
          go-version-file: go.mod
        if: matrix.language == 'go'

      # Autobuild attempts to build any compiled languages (C/C++, C#, Go, Java, or Swift).
      # If this step fails, then you should remove it and run the build manually (see below)
      - name: Autobuild
        uses: github/codeql-action/autobuild@ff0a06e83cb2de871e5a09832bc6a81e7276941f # v3.28.18

@pdabelf5 these steps are now a part of the called workflow (PR with the change is open)

@jjngx jjngx requested a review from a team May 27, 2025 15:38
@jjngx jjngx merged commit e52b1a6 into main May 29, 2025
31 checks passed
@jjngx jjngx deleted the chore/codeql-job branch May 29, 2025 11:35
@AlexFenlon AlexFenlon removed the github_actions Pull requests that update Github_actions code label Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0