8000 Add redirect support in VS/VSR by Dean-Coakley · Pull Request #778 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Add redirect support in VS/VSR #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 28, 2019
Merged

Add redirect support in VS/VSR #778

merged 4 commits into from
Nov 28, 2019

Conversation

Dean-Coakley
Copy link
Contributor

Proposed changes

  • Add an action redirect which allow redirection of http traffic to https to be configured in the VirtualServer.

Example configuration:

action:
  redirect:
    code: 301
    url: http://www.nginx.org

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley Dean-Coakley added the enhancement Pull requests for new features/feature enhancements label Nov 27, 2019
@Dean-Coakley Dean-Coakley self-assigned this Nov 27, 2019
Rulox
Rulox approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor
@Rulox Rulox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few suggestions, otherwise looks good! 🚢

pleshakov
pleshakov suggested changes Nov 27, 2019
View reviewed changes
Copy link
Contributor
@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a number of suggestions and consistency notes

pleshakov
pleshakov approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor
@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dean-Coakley looks good to me. Please take a look at the renaming suggestion before merging?
@Rulox could you take a look one more time?

Rulox
Rulox approved these changes Nov 28, 2019
View reviewed changes
< 8000 /span> Copy link
Contributor
@Rulox Rulox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :shipit:

@Dean-Coakley Dean-Coakley merged commit de8d384 into master Nov 28, 2019
@Dean-Coakley Dean-Coakley deleted the redirects-vs branch November 28, 2019 12:24
@pleshakov pleshakov changed the title Add redirect support in VS Add redirect support in VS/VSR Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@pleshakov pleshakov pleshakov approved these changes

@Rulox Rulox Rulox approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Dean-Coakley Dean-Coakley

Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dean-Coakley @pleshakov @Rulox
0