8000 Add ; in oidc files by vepatel · Pull Request #7748 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Add ; in oidc files #7748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2025
Merged

Add ; in oidc files #7748

merged 1 commit into from
May 6, 2025

Conversation

vepatel
Copy link
Contributor
@vepatel vepatel commented May 6, 2025 •
edited
Loading

Proposed changes

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner May 6, 2025 14:42
@github-actions github-actions bot added the bug An issue reporting a potential bug label May 6, 2025
@vepatel vepatel linked an issue May 6, 2025 that may be closed by this pull request
Update OIDC reference implementation #7266
Closed
6 tasks
@vepatel vepatel merged commit f4ed950 into main May 6, 2025
30 checks passed
@vepatel vepatel deleted the fix/oidc-update-7722 branch May 6, 2025 14:52
@vepatel vepatel mentioned this pull request May 6, 2025
Closed
vepatel added a commit that referenced this pull request May 6, 2025
@vepatel
Revert "add ; in oidc files (#7748)"
c2a7224 
This reverts commit f4ed950.
@AlexFenlon AlexFenlon changed the title add ; in oidc files Add ; in oidc files Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javorszky javorszky javorszky approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

Assignees
No one assigned
Labels
bug An issue reporting a potential bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update OIDC reference implementation
3 participants
@vepatel @javorszky @AlexFenlon
0