10BC0 Update tech spec with supported versions by vepatel · Pull Request #7674 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Update tech spec with supported versions #7674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 17, 2025
Merged

Update tech spec with supported versions #7674

merged 3 commits into from
Apr 17, 2025

Conversation

vepatel
Copy link
Contributor
@vepatel vepatel commented Apr 17, 2025 •
edited
Loading

Proposed changes

  • update tech spec with supported versions

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested review from a team as code owners April 17, 2025 10:48
@vepatel vepatel added the needs cherry pick Cherry pick this PR into a release branch label Apr 17, 2025
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Apr 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/7674/

@vepatel vepatel enabled auto-merge (squash) April 17, 2025 10:50
pdabelf5
pdabelf5 previously approved these changes Apr 17, 2025
View reviewed changes
ADubhlaoich
ADubhlaoich previously approved these changes Apr 17, 2025
View reviewed changes
Copy link
Contributor
@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: got one edit suggestion for the table headings.

@vepatel @ADubhlaoich
Update language
0fe1c7e 
Co-authored-by: Alan Dooley <a.dooley@f5.com>
Signed-off-by: Venktesh Shivam Patel <ve.patel@f5.com>
@vepatel vepatel dismissed stale reviews from ADubhlaoich and pdabelf5 via 0fe1c7e April 17, 2025 13:24
@vepatel vepatel merged commit 195dd2a into main Apr 17, 2025
30 checks passed
@vepatel vepatel deleted the docs/update-tech-spec branch April 17, 2025 13:49
nginx-bot pushed a commit that referenced this pull request Apr 17, 2025
@vepatel @web-flow
update tech spec with supported versions (#7674)
ab99729
@AlexFenlon AlexFenlon changed the title update tech spec with supported versions Update tech spec with supported versions Jun 23, 2025
@AlexFenlon AlexFenlon removed the needs cherry pick Cherry pick this PR into a release branch label Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vepatel @ADubhlaoich @pdabelf5 @AlexFenlon
0