8000 replace patch with delete and create by vepatel · Pull Request #7638 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

replace patch with delete and create #7638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 14, 2025
Merged

replace patch with delete and create #7638

merged 3 commits into from
Apr 14, 2025
+2 −2

Conversation

vepatel
Copy link
Contributor
@vepatel vepatel commented Apr 14, 2025 •
edited
Loading

Proposed changes

  • replace patch api call with delete and create

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner April 14, 2025 09:16
@github-actions github-actions bot added python Pull requests that update Python code tests Pull requests that update tests labels Apr 14, 2025
@vepatel vepatel enabled auto-merge (squash) April 14, 2025 09:45
@vepatel vepatel merged commit 11183b8 into main Apr 14, 2025
80 checks passed
@vepatel vepatel deleted the chore/update-vs-rl-test-lib branch April 14, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

Assignees
No one assigned
Labels
python Pull requests that update Python code tests Pull requests that update tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vepatel @AlexFenlon @pdabelf5
0