8000 Rate limit with zone sync and scale by pdabelf5 · Pull Request #7521 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Rate limit with zone sync and scale #7521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Mar 25, 2025
Merged

Rate limit with zone sync and scale #7521

merged 17 commits into from
Mar 25, 2025

Conversation

pdabelf5
Copy link
Collaborator
@pdabelf5 pdabelf5 commented Mar 17, 2025 •
edited
Loading

Proposed changes

This change updates ratelimiting on Ingress, VirtualServer & VirtualServerRoute resources to use sync'd zone data when zone sync is enabled and suppress the scale parameter

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner March 17, 2025 11:19
@github-actions github-actions bot added go Pull requests that update Go code python Pull requests that update Python code chore Pull requests for routine tasks tests Pull requests that update tests labels Mar 17, 2025
@codecov Codecov
Copy link
codecov bot commented Mar 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 61.70213% with 18 lines in your changes missing coverage. Please review.

Project coverage is 52.08%. Comparing base (368c889) to head (42475e8).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/configs/virtualserver.go 63.15% 10 Missing and 4 partials ⚠️
internal/configs/ingress.go 55.55% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7521      +/-   ##
==========================================
- Coverage   52.09%   52.08%   -0.01%     
==========================================
  Files          89       89              
  Lines       21283    21312      +29     
==========================================
+ Hits        11087    11100      +13     
- Misses       9734     9744      +10     
- Partials      462      468       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot removed the chore Pull requests for routine tasks label Mar 17, 2025
@pdabelf5 pdabelf5 linked an issue Mar 17, 2025 that may be closed by this pull request
Ensure zone_sync takes priority over scale setting for RateLimit policy #7398
Closed
3 tasks
@pdabelf5 pdabelf5 moved this from Todo ☑ to In Review 👀 in NGINX Ingress Controller Mar 17, 2025
@pdabelf5 pdabelf5 enabled auto-merge (squash) March 25, 2025 13:37
@pdabelf5 pdabelf5 merged commit df1119e into main Mar 25, 2025
80 checks passed
@pdabelf5 pdabelf5 deleted the scale-no-warnings branch March 25, 2025 13:48
@github-project-automation github-project-automation bot moved this from In Review 👀 to Done 🚀 in NGINX Ingress Controller Mar 25, 2025
@pdabelf5 pdabelf5 added enhancement Pull requests for new features/feature enhancements and removed go Pull requests that update Go code python Pull requests that update Python code tests Pull requests that update tests labels Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haywoodsh haywoodsh haywoodsh approved these changes

+1 more reviewer

@jjngx jjngx jjngx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@AlexFenlon AlexFenlon

@pdabelf5 pdabelf5

Labels
enhancement Pull requests for new features/feature enhancements
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure zone_sync takes priority over scale setting for RateLimit policy
4 participants
@pdabelf5 @haywoodsh @jjngx @AlexFenlon
0