8000 Documentation for jwt claim based tiered rate limit by haywoodsh · Pull Request #7419 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for jwt claim based tiered rate limit #7419

Merged
merged 8 commits into from
Mar 4, 2025

Conversation

haywoodsh
Copy link
Contributor
@haywoodsh haywoodsh commented Feb 27, 2025

Proposed changes

Add documentation on tiered rate limit with JWT claim and update CRD field description.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added documentation Pull requests/issues for documentation go Pull requests that update Go code labels Feb 27, 2025
@haywoodsh haywoodsh changed the title update docs and crd descriptions Documentation for jwt claim based tiered rate limit Feb 27, 2025
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/7419/

Copy link
codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.76%. Comparing base (e2e1490) to head (39fc6d4).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7419      +/-   ##
==========================================
+ Coverage   52.74%   52.76%   +0.01%     
==========================================
  Files          89       89              
  Lines       21267    21267              
==========================================
+ Hits        11217    11221       +4     
+ Misses       9584     9582       -2     
+ Partials      466      464       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
@haywoodsh haywoodsh force-pushed the docs/jwt-tiered-rate-limiting branch from 5f01656 to 652a1fc Compare March 3, 2025 12:38
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
@haywoodsh haywoodsh marked this pull request as ready for review March 3, 2025 12:49
@haywoodsh haywoodsh requested review from a team as code owners March 3, 2025 12:49
@haywoodsh haywoodsh enabled auto-merge (squash) March 4, 2025 09:42
@haywoodsh haywoodsh merged commit c279908 into main Mar 4, 2025
85 checks passed
@haywoodsh haywoodsh deleted the docs/jwt-tiered-rate-limiting branch March 4, 2025 16:15
@haywoodsh haywoodsh linked an issue Mar 5, 2025 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation - Rate Limiting based on a claim
6 participants
0