8000 Add tracking.info and copy into plus images by javorszky · Pull Request #7400 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Add tracking.info and copy into plus images #7400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 25, 2025
Merged

Add tracking.info and copy into plus images #7400

merged 6 commits into from
Feb 25, 2025

Conversation

javorszky
Copy link
Contributor

Closes #7360

Proposed changes

  • adds a dependencies/tracking.info.default file that is mounted into the docker images that include nginx plus
  • file contains attribution to nic
  • dockerfile also has comments explaining the inclusion

This is potentially a stopgap solution until we have time to look at startup order.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@javorszky javorszky requested a review from a team as a code owner February 24, 2025 13:56
@github-actions github-actions bot added bug An issue reporting a potential bug docker Pull requests that update Docker code labels Feb 24, 2025
@javorszky
Add tracking.info and copy into plus images
bdb1e83 
Closes #7360

* adds a `dependencies/tracking.info.default` file that is mounted into the docker images that include nginx plus
* file contains attribution to nic
* dockerfile also has comments explaining the inclusion

This is potentially a stopgap solution until we have time to look at startup order.
@javorszky javorszky force-pushed the fix/7360-multiple-usage-requests branch from fecef1c to bdb1e83 Compare February 24, 2025 13:57
pdabelf5
pdabelf5 reviewed Feb 24, 2025
View reviewed changes
Copy link
Collaborator
@pdabelf5 pdabelf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the file was add in the nginx-files stage, it could be copied in each plus stage without needing an additional layer

@javorszky
Copy link
Contributor Author

if the file was add in the nginx-files stage, it could be copied in each plus stage without needing an additional layer

Moved this in a new commit. I'll squash these together before merging if all is good 🙂

pdabelf5
pdabelf5 reviewed Feb 24, 2025
View reviewed changes
@javorszky javorszky merged commit 46fcf92 into main Feb 25, 2025
81 checks passed
@javorszky javorszky deleted the fix/7360-multiple-usage-requests branch February 25, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdabelf5 pdabelf5 pdabelf5 approved these changes

+1 more reviewer

@jjngx jjngx jjngx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug An issue reporting a potential bug docker Pull requests that update Docker code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Multiple usage requests sent during helm install/upgrade
3 participants
@javorszky @jjngx @pdabelf5
0