8000 Add VS/VSR Prometheus metrics by Dean-Coakley · Pull Request #724 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Add VS/VSR Prometheus metrics #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 17, 2019
Merged

Add VS/VSR Prometheus metrics #724

merged 7 commits into from
Oct 17, 2019

Conversation

Dean-Coakley
Copy link
Contributor
@Dean-Coakley Dean-Coakley commented Oct 11, 2019 •
edited
Loading

Proposed changes

The IC now exports metrics for the number of VirtualServers and VirtualServerRoutes it is currently handling.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley Dean-Coakley added the enhancement Pull requests for new features/feature enhancements label Oct 11, 2019
@Dean-Coakley Dean-Coakley self-assigned this Oct 11, 2019
Rulox
Rulox suggested changes Oct 15, 2019
View reviewed changes
8000 Copy link
Contributor
@Rulox Rulox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, a small suggestion in the readme , maybe it doesn't make sense so let me know.

pleshakov
pleshakov suggested changes Oct 16, 2019
View reviewed changes
Copy link
Contributor
@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 8000

@Dean-Coakley good job! just style consistently/suggestions

pleshakov
pleshakov approved these changes Oct 17, 2019
View reviewed changes
@Dean-Coakley Dean-Coakley merged commit 4d104e7 into master Oct 17, 2019
@Dean-Coakley Dean-Coakley deleted the add-vs-prom-metrics branch October 17, 2019 09:21
@Dean-Coakley Dean-Coakley mentioned this pull request Oct 21, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@pleshakov pleshakov pleshakov approved these changes

@Rulox Rulox Rulox approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Dean-Coakley Dean-Coakley

Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dean-Coakley @pleshakov @Rulox
0