8000 Allow newline in helm helpers when enabling debug by pdabelf5 · Pull Request #7230 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Allow newline in helm helpers when enabling debug #7230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 5, 2025
Merged

Allow newline in helm helpers when enabling debug #7230

merged 8 commits into from
Feb 5, 2025

Conversation

pdabelf5
Copy link
Collaborator
@pdabelf5 pdabelf5 commented Jan 28, 2025 •
edited
Loading

Proposed changes

The debug configuration was not working for helm installations, delve & nic parameters were running on one line. This change allows the newline to occur.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner January 28, 2025 11:57
@github-actions github-actions bot added the helm_chart Pull requests that update the Helm Chart label Jan 28, 2025
@pdabelf5 pdabelf5 enabled auto-merge (squash) January 30, 2025 09:02
@github-actions github-actions bot added the go Pull requests that update Go code label Jan 30, 2025
@codecov Codecov
Copy link
codecov bot commented Jan 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.74%. Comparing base (24cf076) to head (6187fc7).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7230   +/-   ##
=======================================
  Coverage   52.74%   52.74%           
=======================================
  Files          89       89           
  Lines       20886    20886           
=======================================
  Hits        11016    11016           
  Misses       9407     9407           
  Partials      463      463

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 merged commit 1bf57cd into main Feb 5, 2025
80 checks passed
@pdabelf5 pdabelf5 deleted the debug-helm branch February 5, 2025 14:55
@pdabelf5 pdabelf5 changed the title allow newline in helm helpers when enabling debug Allow newline in helm helpers when enabling debug Apr 4, 2025
@pdabelf5 pdabelf5 added skip changelog Pull requests that don't need to be added to the changelog and removed go Pull requests that update Go code helm_chart Pull requests that update the Helm Chart labels Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

+1 more reviewer

@jjngx jjngx jjngx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
skip changelog Pull requests that don't need to be added to the changelog
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pdabelf5 @vepatel @AlexFenlon @jjngx
0