10000 Correct typo in helm lease annotations template by nginx-bot · Pull Request #7188 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Correct typo in helm lease annotations template #7188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 22, 2025
Merged

Correct typo in helm lease annotations template #7188

merged 2 commits into from
Jan 22, 2025

Conversation

nginx-bot
Copy link
Contributor

Proposed changes

The syntax for the helm template controller-lease.yaml was incorrect for annotations. This change addresses the issue by adding the required : to make the yaml valid.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@nginx-bot nginx-bot requested a review from a team as a code owner January 22, 2025 11:45
@nginx-bot nginx-bot added helm_chart Pull requests that update the Helm Chart needs cherry pick Cherry pick this PR into a release branch labels Jan 22, 2025
@pdabelf5 pdabelf5 added bug An issue reporting a potential bug and removed needs cherry pick Cherry pick this PR into a release branch labels Jan 22, 2025
@pdabelf5 pdabelf5 changed the title [cherry-pick] Correct typo in helm lease annotations template Correct typo in helm lease annotations template Jan 22, 2025
@pdabelf5 pdabelf5 enabled auto-merge (squash) January 22, 2025 11:46
@pdabelf5 pdabelf5 self-assigned this Jan 22, 2025
@github-actions github-actions bot removed the bug An issue reporting a potential bug label Jan 22, 2025
@pdabelf5 pdabelf5 merged commit 2344719 into release-4.0 Jan 22, 2025
62 checks passed
@pdabelf5 pdabelf5 deleted the cherry-pick-release-4.0-ec4aceeb5984a1b646de471c235f748e734dc3a0 branch January 22, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

Assignees

@pdabelf5 pdabelf5

Labels
helm_chart Pull requests that update the Helm Chart
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nginx-bot @vepatel @AlexFenlon @pdabelf5
0