refactor: replace golang.org/x/exp with stdlib
#7131
Conversation
|
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
|
I have hereby read the F5 CLA and agree to its terms |
There was a problem hiding this comment.
Nice, thank you! Notably the signature for maps.Keys changed between the exp package and std library, which is why the slices.Collect is there.
Also checked the rest of the codebase, no other place uses exp/maps or exp/slices.
These experimental packages are now available in the Go standard library: 1. golang.org/x/exp/slices -> slices [1] 2. golang.org/x/exp/maps -> maps [2] [1]: https://go.dev/doc/go1.21#slices [2]: https://go.dev/doc/go1.21#maps Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
|
Rebased to fix conflicts.
|
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
|
@javorszky Thanks you reviewing and approving the PR 😊 ! Seems like the workflow needs your approval again to run |
|
@Juneezee it's running 2 more checks at the time of writing this comment. I expect both to finish, and the PR to be merged as soon as both return green. Thanks for fixing these! |
only to open up another 16... 😆 Right, working on these |
* refactor: replace `golang.org/x/exp` with stdlib These experimental packages are now available in the Go standard library: 1. golang.org/x/exp/slices -> slices [1] 2. golang.org/x/exp/maps -> maps [2] [1]: https://go.dev/doc/go1.21#slices [2]: https://go.dev/doc/go1.21#maps Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> * Fix TestGetEndpointSlicesBySubselectedPods_GetsEndpointsOnNilValues Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> --------- Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Proposed changes
These experimental packages are now available in the Go standard library.
golang.org/x/exp/slices->slices(https://go.dev/doc/go1.21#slices)golang.org/x/exp/maps->maps(https://go.dev/doc/go1.21#maps)Checklist
Before creating a PR, run through this checklist and mark each as complete.