8000 Add reminder to delete nginx-ingress ClusterRole by mattwahner · Pull Request #713 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Add reminder to delete nginx-ingress ClusterRole #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2019
Merged

Add reminder to delete nginx-ingress ClusterRole #713

merged 1 commit into from
Oct 3, 2019

Conversation

mattwahner
Copy link
Contributor

Proposed changes

When a user attempts to uninstall everything that is created in the nginx-ingress namespace, they may have not deleted the RBAC ClusterRole added in step 2. This note ensures they delete that role as well so that all resources are deleted when uninstalling nginx-ingress.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Rulox Rulox added the documentation Pull requests/issues for documentation label Oct 1, 2019
Dean-Coakley
Dean-Coakley approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor
@Dean-Coakley Dean-Coakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me:
ClusterRole and ClusterRoleBinding are cluster wide/not namespaced resources and are not cleaned up by the kubectl delete namespace nginx-ingress command.

Thanks for the PR!

pleshakov
pleshakov approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor
@pleshakov pleshakov left a comment
A40F

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pleshakov pleshakov merged commit c71b7f8 into nginx:master Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rulox Rulox Awaiting requested review from Rulox

2 more reviewers

@pleshakov pleshakov pleshakov approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattwahner @pleshakov @Dean-Coakley @Rulox
0