8000 Add OIDC fix for ID token nonce claim validation by nginx-bot · Pull Request #6761 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Add OIDC fix for ID token nonce claim validation #6761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2024
Merged

Add OIDC fix for ID token nonce claim validation #6761

merged 1 commit into from
Nov 6, 2024

Conversation

nginx-bot
Copy link
Contributor

Proposed changes

Fix for OIDC js: ID token nonce claim validation

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@nginx-bot nginx-bot requested a review from a team as a code owner November 6, 2024 15:51
@nginx-bot nginx-bot added bug An issue reporting a potential bug chore Pull requests for routine tasks needs cherry pick Cherry pick this PR into a release branch labels Nov 6, 2024
@github-actions github-actions bot removed the bug An issue reporting a potential bug label Nov 6, 2024
@pdabelf5 pdabelf5 added bug An issue reporting a potential bug and removed chore Pull requests for routine tasks needs cherry pick Cherry pick this PR into a release branch labels Nov 6, 2024
@pdabelf5 pdabelf5 changed the title [cherry-pick] Add OIDC fix for ID token nonce claim validation Add OIDC fix for ID token nonce claim validation Nov 6, 2024
@pdabelf5 pdabelf5 enabled auto-merge (squash) November 6, 2024 15:54
@codecov Codecov
Copy link
codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-3.7@d21cca6). Learn more about missing BASE report.

Additional details and impacted files 
@@              Coverage Diff               @@
##             release-3.7    #6761   +/-   ##
==============================================
  Coverage               ?   52.97%           
==============================================
  Files                  ?       85           
  Lines                  ?    19764           
  Branches               ?        0           
==============================================
  Hits                   ?    10469           
  Misses                 ?     8887           
  Partials               ?      408

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 merged commit 0fbe529 into release-3.7 Nov 6, 2024
72 checks passed
@pdabelf5 pdabelf5 deleted the cherry-pick-release-3.7-b90209f93be48fdc8d387e623153a41240e6dfcd branch November 6, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

+1 more reviewer

@jjngx jjngx jjngx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug An issue reporting a potential bug
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nginx-bot @AlexFenlon @jjngx @pdabelf5
0