8000 Add ClientBodyMaxSize support in vs/vsr by Dean-Coakley · Pull Request #660 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Add ClientBodyMaxSize support in vs/vsr #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2019
Merged

Add ClientBodyMaxSize support in vs/vsr #660

merged 1 commit into from
Aug 20, 2019

Conversation

Dean-Coakley
Copy link
Contributor

Proposed changes

Support configuring client max body size in upstreams of VirtualServer/VirtualServerRoute.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley Dean-Coakley added the enhancement Pull requests for new features/feature enhancements label Aug 15, 2019
@Dean-Coakley Dean-Coakley self-assigned this Aug 15, 2019
pleshakov
pleshakov suggested changes Aug 15, 2019
View reviewed changes
Copy link
Contributor
@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dean-Coakley thanks for the PR. Please see my comments.

Rulox
Rulox approved these changes Aug 16, 2019
View reviewed changes
Copy link
Contributor
@Rulox Rulox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once addressed @pleshakov comments!

pleshakov
pleshakov suggested changes Aug 16, 2019
View reviewed changes
Copy link
Contributor
@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dean-Coakley looks good!
Please see my comments.

LorcanMcVeigh
LorcanMcVeigh approved these changes Aug 19, 2019
View reviewed changes
Copy link
Contributor
@LorcanMcVeigh LorcanMcVeigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

pleshakov
pleshakov suggested changes Aug 19, 2019
View reviewed changes
Copy link
Contributor
@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small comments

8000
pleshakov
pleshakov approved these changes Aug 19, 2019
View reviewed changes
@Dean-Coakley Dean-Coakley force-pushed the support-client-body-max-size-vs-vsr branch from f0fdfc0 to ddd8023 Compare August 20, 2019 07:46
@Dean-Coakley Dean-Coakley merged commit 21c1981 into master Aug 20, 2019
@Dean-Coakley Dean-Coakley deleted the support-client-body-max-size-vs-vsr branch August 20, 2019 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvighnesha bvighnesha Awaiting requested review from bvighnesha

@ampant ampant Awaiting requested review from ampant

3 more reviewers

@pleshakov pleshakov pleshakov approved these changes

@Rulox Rulox Rulox approved these changes

@LorcanMcVeigh LorcanMcVeigh LorcanMcVeigh approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Dean-Coakley Dean-Coakley

Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Dean-Coakley @pleshakov @Rulox @LorcanMcVeigh
0