10000 Generate valid yaml for readOnly fs by jjngx · Pull Request #6583 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Generate valid yaml for readOnly fs #6583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2024
Merged

Generate valid yaml for readOnly fs #6583

merged 1 commit into from
Oct 3, 2024

Conversation

jjngx
Copy link
Contributor
@jjngx jjngx commented Oct 3, 2024 •
edited by j1m-ryan
Loading

Co-authored-by: Jim Ryan j.ryan@f5.com

Proposed changes

This PR fixes an issue causing Helm to crash when the readOnlyRootFilesystem option was on the NIC container, and WAF was enabled simultaneously

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx
Generate valid yaml for readOnly fs
efe1ce3 
Co-authored-by: Jim Ryan j.ryan@f5.com
@jjngx jjngx requested a review from a team as a code owner October 3, 2024 11:23
@jjngx jjngx requested a review from j1m-ryan October 3, 2024 11:24
@github-actions github-actions bot added bug An issue reporting a potential bug helm_chart Pull requests that update the Helm Chart labels Oct 3, 2024
@jjngx jjngx merged commit 3253295 into main Oct 3, 2024
80 checks passed
@jjngx jjngx deleted the fix/helm-inden 9711 tation branch October 3, 2024 13:11
@jjngx jjngx mentioned this pull request Oct 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

+1 more reviewer

@j1m-ryan j1m-ryan j1m-ryan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug An issue reporting a potential bug helm_chart Pull requests that update the Helm Chart
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jjngx @j1m-ryan @AlexFenlon @pdabelf5
0