8000 Add LogLevel & LogFormat flags by AlexFenlon · Pull Request #6520 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Add LogLevel & LogFormat flags #6520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Sep 27, 2024
Merged

Add LogLevel & LogFormat flags #6520

merged 21 commits into from
Sep 27, 2024

Conversation

AlexFenlon
Copy link
Contributor

Proposed changes

  • added LogLevel parameter to Ingress Controller
  • added LogFormat parameter to Ingress Controller
  • refactored logLevel in helm chart
  • deprecated glog -v= format
  • added tests for LogFormat and LogLevel
  • initiated the log handler requred for structured logs in preperation for future work
  • glog is set as default for logFormat to keep consistancy until glog is fully replaced

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my 8000 branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@AlexFenlon AlexFenlon requested a review from a team as a code owner September 26, 2024 15:41
@github-actions github-actions bot added enhancement Pull requests for new features/feature enhancements go Pull requests that update Go code helm_chart Pull requests that update the Helm Chart labels Sep 26, 2024
@codecov Codecov
Copy link
codecov bot commented Sep 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 64.70588% with 12 lines in your changes missing coverage. Please review.

Project coverage is 53.36%. Comparing base (3d3284f) to head (f689e48).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
cmd/nginx-ingress/flags.go 46.66% 8 Missing ⚠️
cmd/nginx-ingress/main.go 78.94% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6520      +/-   ##
==========================================
+ Coverage   53.30%   53.36%   +0.05%     
==========================================
  Files          87       87              
  Lines       16074    16104      +30     
==========================================
+ Hits         8569     8594      +25     
- Misses       7097     7102       +5     
  Partials      408      408

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pdabelf5
pdabelf5 approved these changes Sep 26, 2024
View reviewed changes
pdabelf5
pdabelf5 reviewed Sep 27, 2024
View reviewed changes
pdabelf5
pdabelf5 reviewed Sep 27, 2024
View reviewed changes
Copy link
Collaborator
@pdabelf5 pdabelf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need docs updates for log-level & log-format parameters

@AlexFenlon AlexFenlon requested a review from a team as a code owner September 27, 2024 08:58
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Sep 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/6520/

jjngx
jjngx approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor
@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

j1m-ryan
j1m-ryan reviewed Sep 27, 2024
View reviewed changes
@AlexFenlon AlexFenlon added the change Pull requests that introduce a change label Sep 27, 2024
@AlexFenlon AlexFenlon enabled auto-merge (squash) September 27, 2024 10:18
@AlexFenlon AlexFenlon disabled auto-merge September 27, 2024 10:18
@AlexFenlon AlexFenlon mentioned this pull request Sep 27, 2024
Closed
16 tasks
@AlexFenlon AlexFenlon enabled auto-merge (squash) September 27, 2024 10:22
@AlexFenlon AlexFenlon merged commit 914c9e2 into main Sep 27, 2024
83 checks passed
@AlexFenlon AlexFenlon deleted the feat/logformat-flag branch September 27, 2024 10:31
@AlexFenlon AlexFenlon mentioned this pull request Oct 8, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

+2 more reviewers

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@jjngx jjngx jjngx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@AlexFenlon AlexFenlon

@pdabelf5 pdabelf5

Labels
change Pull requests that introduce a change documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements go Pull requests that update Go code helm_chart Pull requests that update the Helm Chart
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AlexFenlon @ADubhlaoich @j1m-ryan @jjngx @pdabelf5
0