8000 update go version by j1m-ryan · Pull Request #6368 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

update go version #6368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 6, 2024
Merged

update go version #6368

merged 2 commits into from
Sep 6, 2024

Conversation

j1m-ryan
Copy link
@j1m-ryan j1m-ryan commented Sep 6, 2024

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to
that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@j1m-ryan j1m-ryan requested a review from a team as a code owner September 6, 2024 10:56
@github-actions github-actions bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Sep 6, 2024
@j1m-ryan j1m-ryan enabled auto-merge (squash) September 6, 2024 11:00
@codecov Codecov
Copy link
codecov bot commented Sep 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.14%. Comparing base (c1e2906) to head (45f4b10).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6368      +/-   ##
==========================================
- Coverage   53.15%   53.14%   -0.02%     
==========================================
  Files          81       81              
  Lines       15967    15967              
==========================================
- Hits         8488     8486       -2     
- Misses       7074     7076       +2     
  Partials      405      405

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
8000

@j1m-ryan j1m-ryan merged commit a83b7be into main Sep 6, 2024
79 checks passed
@j1m-ryan j1m-ryan deleted the chore/update-go branch September 6, 2024 11:32
nginx-bot pushed a commit that referenced this pull request Sep 6, 2024
@web-flow
update go version (#6368)
1be3355
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j1m-ryan @vepatel @AlexFenlon
0