8000 update go version format by vepatel · Pull Request #6350 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

update go version format #6350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2024
Merged

update go version format #6350

merged 2 commits into from
Sep 4, 2024

Conversation

vepatel
Copy link
Contributor
@vepatel vepatel commented Sep 4, 2024 •
edited
Loading

Proposed changes

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner September 4, 2024 15:12
@github-actions github-actions bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Sep 4, 2024
@vepatel vepatel enabled auto-merge (squash) September 4, 2024 15:18
@codecov Codecov
Copy link
codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.01%. Comparing base (ccd88fd) to head (7d285ed).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6350   +/-   ##
=======================================
  Coverage   53.01%   53.01%           
=======================================
  Files          79       80    +1     
  Lines       15921    15921           
=======================================
  Hits         8441     8441           
  Misses       7073     7073           
  Partials      407      407

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vepatel vepatel requested a review from jjngx September 4, 2024 15:37
@vepatel vepatel merged commit d0e56e9 into main Sep 4, 2024
77 checks passed
@vepatel vepatel deleted the chore/update-1.n.p-format branch September 4, 2024 16:00
nginx-bot pushed a commit that referenced this pull request Sep 4, 2024
@vepatel @web-flow
update go version format (#6350)
fc5e978
@vepatel vepatel self-assigned this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

@jjngx jjngx Awaiting requested review from jjngx

+1 more reviewer

@j1m-ryan j1m-ryan j1m-ryan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@vepatel vepatel

Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vepatel @j1m-ryan @AlexFenlon @pdabelf5
0