10000 Update helm docs by vepatel · Pull Request #6235 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Update helm docs #6235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 19, 2024
Merged

Update helm docs #6235

merged 6 commits into from
Aug 19, 2024

Conversation

vepatel
Copy link
Contributor
@vepatel vepatel commented Aug 19, 2024

Proposed changes

  • Replace content with docs url

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner August 19, 2024 09:24
@github-actions github-actions bot added documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart labels Aug 19, 2024
@vepatel vepatel requested review from ADubhlaoich and a team August 19, 2024 09:24
@vepatel vepatel added the needs cherry pick Cherry pick this PR into a release branch label Aug 19, 2024
pdabelf5
pdabelf5 reviewed 8000 Aug 19, 2024
View reviewed changes
@github-actions github-actions bot added the chore Pull requests for routine tasks label Aug 19, 2024
pdabelf5
pdabelf5 requested changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator
@pdabelf5 pdabelf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FILE_TO_UPDATE_HELM_CHART_VERSION=(
"${HELM_CHART_PATH}/Chart.yaml"
"${HELM_CHART_PATH}/README.md" # to be removed
)

JTorreG
JTorreG reviewed Aug 19, 2024
View reviewed changes
@vepatel vepatel enabled auto-merge (squash) August 19, 2024 10:54
@vepatel vepatel merged commit 7c5e8fa into main Aug 19, 2024
@vepatel vepatel deleted the docs/update-helm-readme branch August 19, 2024 10:56
nginx-bot pushed a commit that referenced this pull request Aug 19, 2024
@vepatel @web-flow
update helm docs (#6235)
c759037
@ADubhlaoich ADubhlaoich mentioned this pull request Aug 19, 2024
Closed
@pdabelf5 pdabelf5 removed the chore Pull requests for routine tasks label Sep 23, 2024
@pdabelf5 pdabelf5 changed the title update helm docs Update helm docs Sep 23, 2024
@pdabelf5 pdabelf5 removed documentation Pull requests/issues for documentation needs cherry pick Cherry pick this PR into a release branch labels Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JTorreG JTorreG JTorreG left review comments

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

+1 more reviewer

@j1m-ryan j1m-ryan j1m-ryan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
helm_chart Pull requests that update the Helm Chart
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vepatel @ADubhlaoich @j1m-ryan @AlexFenlon @JTorreG @pdabelf5
0