8000 Add keepalive support to vs/vsr by Dean-Coakley · Pull Request #617 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Add keepalive support to vs/vsr #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 10, 2019
Merged

Add keepalive support to vs/vsr #617

merged 8 commits into from
Jul 10, 2019

Conversation

Dean-Coakley
Copy link
Contributor

Proposed changes

Support configuring keepalive connections in upstreams of VirtualServer/VirtualServerRoute.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch ont 8000 o master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley Dean-Coakley added the enhancement Pull requests for new features/feature enhancements label Jul 5, 2019
@Dean-Coakley Dean-Coakley self-assigned this Jul 5, 2019
Rulox
Rulox suggested changes Jul 8, 2019
View reviewed changes
Copy link
Contributor
@Rulox Rulox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I have added a few comments tho, let me know if they make sense to you 👍

pleshakov
pleshakov suggested changes Jul 8, 2019
View reviewed changes
Copy link
Contributor
@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my review.

Additionally, I suggest adding keepalive here https://github.com/nginxinc/kubernetes-ingress/blob/master/internal/configs/version2/templates_test.go#L8

Also, the changes in the plus template are missing. Note sure if that was intentional.

@Dean-Coakley Dean-Coakley requested review from Rulox and pleshakov July 9, 2019 15:58
pleshakov
pleshakov suggested changes Jul 10, 2019
View reviewed changes
Copy link
Contributor
@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please see some suggestions though.

pleshakov
pleshakov approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor
@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

LorcanMcVeigh
LorcanMcVeigh reviewed Jul 10, 2019
View reviewed changes
Copy link
Contributor
@LorcanMcVeigh LorcanMcVeigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@Dean-Coakley Dean-Coakley merged commit bc2326e into master Jul 10, 2019
@Dean-Coakley Dean-Coakley deleted the feature/vs-vsr-upstream-keepalive branch July 10, 2019 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
3 more reviewers

@LorcanMcVeigh LorcanMcVeigh LorcanMcVeigh left review comments

@pleshakov pleshakov pleshakov approved these changes

@Rulox Rulox Rulox approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Dean-Coakley Dean-Coakley

Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Dean-Coakley @pleshakov @Rulox @LorcanMcVeigh
0