8000 Change ExternalDNS link to be non-versioned by ADubhlaoich · Pull Request #6140 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Change ExternalDNS link to be non-versioned #6140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2024
Merged

Change ExternalDNS link to be non-versioned #6140

merged 1 commit into from
Aug 6, 2024

Conversation

ADubhlaoich
Copy link
Contributor
@ADubhlaoich ADubhlaoich commented Aug 6, 2024 •
edited
Loading

Proposed changes

When following the link to ExternalDNS, it goes to a specific version. By changing the link to the base URL for the documentation set, it will automatically default to the latest version - ensuring we never link to an outdated version.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ADubhlaoich
Change ExternalDNS link to be non-versioned
68fd9de 
When following the link to ExternalDNS, it goes to a specific version.
By changing the link to the base URL for the documentation set, it will
automatically default to the latest version - ensuring we never link to
an outdated version.
@ADubhlaoich ADubhlaoich requested review from a team as code owners August 6, 2024 15:13
@ADubhlaoich ADubhlaoich self-assigned this Aug 6, 2024
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Aug 6, 2024
@ADubhlaoich ADubhlaoich enabled auto-merge (squash) August 6, 2024 15:14
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Aug 6, 2024

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/6140/

@ADubhlaoich ADubhlaoich merged commit 737d211 into main Aug 6, 2024
@ADubhlaoich ADubhlaoich deleted the change-edns-link branch August 6, 2024 15:23
ADubhlaoich added a commit that referenced this pull request Aug 23, 2024
@ADubhlaoich
Change ExternalDNS link to be non-versioned (#6140)
a3f2653 
When following the link to ExternalDNS, it goes to a specific version.
By changing the link to the base URL for the documentation set, it will
automatically default to the latest version - ensuring we never link to
an outdated version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

+1 more reviewer

@jjngx jjngx jjngx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@ADubhlaoich ADubhlaoich

Labels
documentation Pull requests/issues for documentation
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ADubhlaoich @vepatel @jjngx
0