10000 Add permission to allow PR comments for preview urls by nginx-jack · Pull Request #6082 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Add permission to allow PR comments for preview urls #6082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 30, 2024
Merged

Add permission to allow PR comments for preview urls #6082

merged 10 commits into from
Jul 30, 2024

Conversation

nginx-jack
Copy link
Contributor
@nginx-jack nginx-jack commented Jul 29, 2024 •
edited
Loading

Proposed changes

Add permission to docs build and deploy workflow to allow comments to be created with the preview url.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@nginx-jack nginx-jack requested a review from a team as a code owner July 29, 2024 10:42
@github-actions github-actions bot added github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels Jul 29, 2024
pdabelf5
pdabelf5 reviewed Jul 29, 2024
View reviewed changes
pdabelf5
pdabelf5 reviewed Jul 29, 2024
View reviewed changes
@nginx-jack nginx-jack requested a review from a team as a code owner July 29, 2024 13:14
@github-actions github-actions bot 8000 added the documentation Pull requests/issues for documentation label Jul 29, 2024
@pdabelf5 pdabelf5 merged commit 165963d into nginx:main Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdabelf5 pdabelf5 pdabelf5 approved these changes

@mjang mjang mjang approved these changes

@vepatel vepatel vepatel approved these changes

+1 more reviewer

@j1m-ryan j1m-ryan j1m-ryan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
chore Pull requests for routine tasks documentation Pull requests/issues for documentation github_actions Pull requests that update Github_actions code
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nginx-jack @mjang @j1m-ryan @vepatel @pdabelf5 @ADubhlaoich
0