8000 Update apiVersion in Deployments and DaemonSets to apps/v1 by LorcanMcVeigh · Pull Request #603 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Update apiVersion in Deployments and DaemonSets to apps/v1 #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2019
Merged

Update apiVersion in Deployments and DaemonSets to apps/v1 #603

merged 2 commits into from
Jul 2, 2019

Conversation

LorcanMcVeigh
Copy link
Contributor

Updated the apiVersion in the daemonSet & deployment manifest and the daemonSet & deployment helm template

@LorcanMcVeigh LorcanMcVeigh self-assigned this Jun 25, 2019
@LorcanMcVeigh LorcanMcVeigh force-pushed the update-resource-versions branch from c2811e8 to d2a498e Compare June 25, 2019 12:59
pleshakov
pleshakov approved these changes Jul 2, 2019
View reviewed changes
Copy link
Contributor
@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LorcanMcVeigh
before merging, please squash your 4 commits into a single one

@LorcanMcVeigh LorcanMcVeigh force-pushed the update-resource-versions branch from bb93ef3 to 81a149a Compare July 2, 2019 15:07
Rulox
Rulox approved these changes Jul 2, 2019
View reviewed changes
Copy link
Contributor
@Rulox Rulox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@LorcanMcVeigh remember to Rebase and Merge , also be sure CI is passing before merging (is red right now)

@LorcanMcVeigh LorcanMcVeigh merged commit b38da03 into master Jul 2, 2019
@LorcanMcVeigh LorcanMcVeigh deleted the update-resource-versions branch July 2, 2019 20:26
@pleshakov pleshakov changed the title Update resource versions Update apiVersion in Deployments and DaemonSets to apps/v1 Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
3 more reviewers

@pleshakov pleshakov pleshakov approved these changes

@Rulox Rulox Rulox approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@LorcanMcVeigh LorcanMcVeigh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LorcanMcVeigh @pleshakov @Rulox @Dean-Coakley @tellet
0