8000 Sync oidc repo by haywoodsh · Pull Request #6014 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]

Skip to content

Conversation

haywoodsh
Copy link
Contributor
@haywoodsh haywoodsh commented Jul 12, 2024

Proposed changes

sync changes from oidc repo https://github.com/nginxinc/nginx-openid-connect/pull/96/files

Changes from https://github.com/nginxinc/nginx-openid-connect/pull/96/files#diff-512d27cf176962c2b1cffd370bbd1adba80368558ad4aaa2a6255eea9ff453bdR31-R37 is ignored because the variable should be set from the NGINX conf generated by NIC.

Testing:
Works with existing OIDC keycloak set up on main branch (without logout ).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@haywoodsh haywoodsh force-pushed the chore/sync-oidc-repo branch 3 times, most recently from 193ac39 to a1f4f09 Compare July 15, 2024 11:31
@haywoodsh haywoodsh added dependencies Pull requests that update a dependency file chore Pull requests for routine tasks labels Jul 15, 2024
Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>

Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
@haywoodsh haywoodsh force-pushed the chore/sync-oidc-repo branch from a1f4f09 to 3d4f5e6 Compare July 18, 2024 11:06
@github-actions github-actions bot removed dependencies Pull requests that update a dependency file chore Pull requests for routine tasks labels Jul 18, 2024
@haywoodsh haywoodsh marked this pull request as ready for review July 18, 2024 11:07
@haywoodsh haywoodsh requested a review from a team as a code owner July 18, 2024 11:07
@haywoodsh haywoodsh enabled auto-merge (squash) July 18, 2024 15:23
@haywoodsh haywoodsh merged commit f51b894 into main Jul 18, 2024
@haywoodsh haywoodsh deleted the chore/sync-oidc-repo branch July 18, 2024 15:27
@pdabelf5 pdabelf5 added the enhancement Pull requests for new features/feature enhancements label Sep 23, 2024
@pdabelf5 pdabelf5 changed the title sync oidc repo Sync oidc repo Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants
0