8000 Add BUILD_OS to Telemetry by AlexFenlon · Pull Request #5968 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Add BUILD_OS to Telemetry #5968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 5, 2024
Merged

Add BUILD_OS to Telemetry #5968

merged 7 commits into from
Jul 5, 2024

Conversation

AlexFenlon
Copy link
Contributor

Proposed changes

This collects the base Build_OS whenever an image is build and adds it to telemetry as shown below.

snippet of the log for when debian image with nginx plus is deployed:
BuildOS:debian-plus}}

snippet of the log for when alpine image with nginx oss is deployed:
BuildOS:alpine}}

snippet of the log for when debian image with nginx oss is deployed:
BuildOS:debian}}

Resolves: #5954

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@AlexFenlon AlexFenlon requested review from a team as code owners July 5, 2024 08:23
@github-actions github-actions bot added enhancement Pull requests for new features/feature enhancements documentation Pull requests/issues for documentation go Pull requests that update Go code docker Pull requests that update Docker code labels Jul 5, 2024
pdabelf5
pdabelf5 reviewed Jul 5, 2024
View reviewed changes
jjngx
jjngx reviewed Jul 5, 2024
View reviewed changes
jjngx
jjngx reviewed Jul 5, 2024
View reviewed changes
oseoin
oseoin reviewed Jul 5, 2024
View reviewed changes
@AlexFenlon AlexFenlon changed the title Add Build_OS to Telemetry Add BUILD_OS to Telemetry Jul 5, 2024
@AlexFenlon AlexFenlon requested review from jjngx and pdabelf5 July 5, 2024 10:46
ADubhlaoich
ADubhlaoich reviewed Jul 5, 2024
View reviewed changes
Copy link
Contributor
@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I am not approving since this is primarily a code PR.

@AlexFenlon AlexFenlon merged commit 4f4152c into main Jul 5, 2024
@AlexFenlon AlexFenlon deleted the feat/telemetry-build-os branch July 5, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich left review comments

@pdabelf5 pdabelf5 pdabelf5 approved these changes

+3 more reviewers

@oseoin oseoin oseoin left review comments

@jjngx jjngx jjngx approved these changes

@shaun-nx shaun-nx shaun-nx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
docker Pull requests that update Docker code documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements go Pull requests that update Go code
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Report BUILD_OS of NGINX Ingress Controller
6 participants
@AlexFenlon @ADubhlaoich @oseoin @jjngx @shaun-nx @pdabelf5
0