E53E Pod logs in tests when startup fails by oseoin · Pull Request #5901 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Pod logs in tests when startup fails #5901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 1, 2024
Merged

Pod logs in tests when startup fails #5901

merged 2 commits into from
Jul 1, 2024

Conversation

oseoin
Copy link
Contributor
@oseoin oseoin commented Jul 1, 2024

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to
that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added python Pull requests that update Python code tests Pull requests that update tests labels Jul 1, 2024
@oseoin oseoin marked this pull request as ready for review July 1, 2024 12:31
@oseoin oseoin requested a review from a team as a code owner July 1, 2024 12:31
@oseoin oseoin merged commit 50540ae into main Jul 1, 2024
@oseoin oseoin deleted the add-logs-when-pod-doesnt-start branch July 1, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@jjngx jjngx jjngx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
python Pull requests that update Python code tests Pull requests that update tests
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oseoin @j1m-ryan @jjngx
0