E53B remove sarif artifact upload for images in feature branches by pdabelf5 · Pull Request #5850 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]

Skip to content

Conversation

pdabelf5
Copy link
Collaborator
@pdabelf5 pdabelf5 commented Jun 25, 2024

Proposed changes

The sarif reports for image scans are saved in the Github artifact store on main & release branches, they are not needed on feature branches. However, the scan summaries are included in the PR workflow output.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner June 25, 2024 11:06
@github-actions github-actions bot added github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels Jun 25, 2024
@pdabelf5 pdabelf5 enabled auto-merge (squash) June 25, 2024 12:18
@pdabelf5 pdabelf5 merged commit 1196c8c into main Jun 25, 2024
@pdabelf5 pdabelf5 deleted the sarif-overwrite branch June 25, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks github_actions Pull requests that update Github_actions code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants
0