Remove include-year and includeYear flag
#5817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- commented deprecated include-year and IncludeYear
👷 Deploy request for nginx-kubernetes-ingress pending review.Visit the deploys page to approve it
|
|
Hi @harsha-mangena, thanks for taking this on. Can you delete the flag and docs for the flag instead of commenting it out? |
haywoodsh
requested changes
Jun 24, 2024
- removed commented code.
j1m-ryan
reviewed
Jun 25, 2024
j1m-ryan
reviewed
Jun 25, 2024
docs/content/configuration/global-configuration/command-line-arguments.md
Outdated
Show resolved
Hide resolved
j1m-ryan
reviewed
Jun 25, 2024
j1m-ryan
reviewed
Jun 25, 2024
|
Can you delete the include year arg that is commented out in these files
|
Signed-off-by: harsha-mangena <44197358+harsha-mangena@users.noreply.github.com>
Signed-off-by: harsha-mangena <44197358+harsha-mangena@users.noreply.github.com>
Signed-off-by: harsha-mangena <44197358+harsha-mangena@users.noreply.github.com>
Signed-off-by: harsha-mangena <44197358+harsha-mangena@users.noreply.github.com>
|
The year still shows up (correctly). Thanks for working on this @harsha-mangena |
j1m-ryan
approved these changes
Jun 27, 2024
vepatel
approved these changes
Jun 27, 2024
haywoodsh
approved these changes
Jun 27, 2024
AlexFenlon
pushed a commit
that referenced
this pull request
Jul 1, 2024
* - refer #5776 - commented deprecated include-year and IncludeYear * removed commented code * - made `includeYear` flag as `true` by default. - removed commented code. * - addressed comments * recommit - yaml * removed include-year arg Signed-off-by: harsha-mangena <44197358+harsha-mangena@users.noreply.github.com> * removed include-year arg Signed-off-by: harsha-mangena <44197358+harsha-mangena@users.noreply.github.com> * removed include-year arg Signed-off-by: harsha-mangena <44197358+harsha-mangena@users.noreply.github.com> * removed include-year arg Signed-off-by: harsha-mangena <44197358+harsha-mangena@users.noreply.github.com> --------- Signed-off-by: harsha-mangena <44197358+harsha-mangena@users.noreply.github.com> Co-authored-by: Jim Ryan <j.ryan@f5.com>
include-year and includeYear flaginclude-year and includeYear flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to
that issue here in this description (not in the title of the PR).
- refer Remove includeYear flag #5776
- commented deprecated include-year and IncludeYear
8000Checklist
Before creating a PR, run through this checklist and mark each as complete.