8000 Add `dataType` field to generated attributes by shaun-nx · Pull Request #5261 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Add dataType field to generated attributes #5261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 15, 2024
Merged

Add dataType field to generated attributes #5261

merged 4 commits into from
Mar 15, 2024

Conversation

shaun-nx
Copy link
Contributor
@shaun-nx shaun-nx commented Mar 15, 2024 •
edited
Loading

Proposed changes

Update telemetry-exporter dependency and re-generated attributes and schema.

Ran make telemetry-schema to re-generate all the required files

make telemetry-schema

go generate internal/telemetry/exporter.go
go: downloading github.com/nginxinc/telemetry-exporter v0.0.0-20240307135433-a5ecce59bddf
Successfully parsed struct Data
Generating code
Generating scheme
Successfully parsed struct NICResourceCounts
Generating code
gofumpt -w internal/telemetry/*_generated.go

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@shaun-nx shaun-nx requested a review from a team as a code owner March 15, 2024 17:24
@github-actions github-actions bot added dependencies Pull requests that update a dependency file enhancement Pull requests for new features/feature enhancements labels Mar 15, 2024
@shaun-nx shaun-nx enabled auto-merge (squash) March 15, 2024 17:52
@shaun-nx shaun-nx added this to the v3.5.0 milestone Mar 15, 2024
@shaun-nx shaun-nx merged commit cd54d2c into main Mar 15, 2024
@shaun-nx shaun-nx deleted the feat/telemetry-data-type branch March 15, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

+1 more reviewer

@j1m-ryan j1m-ryan j1m-ryan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@shaun-nx @j1m-ryan @vepatel
0