8000 Bump Go version to 1.22.1 by jjngx · Pull Request #5208 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Bump Go version to 1.22.1 #5208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 7, 2024
Merged

Bump Go version to 1.22.1 #5208

merged 2 commits into from
Mar 7, 2024

Conversation

jjngx
Copy link
Contributor
@jjngx jjngx commented Mar 6, 2024 •
edited
Loading

Proposed changes

Upgrade Go to v1.22.1

➜  ~ k logs --follow -n nginx-ingress nginx-ingress-9b9b8f76b-7tprm
NGINX Ingress Controller Version=3.5.0-SNAPSHOT Commit=00865d93ff3c8e00bcac258f70d8865f121bea86 Date=2024-03-06T19:39:12Z DirtyState=false Arch=linux/amd64 Go=go1.22.1
I0306 19:41:10.296806       1 flags.go:304] Starting with flags: ["-nginx-plus" "-nginx-configmaps=nginx-ingress/nginx-config" "-enable-custom-resources" "-enable-tls-passthrough" "-v=3" "-enable-prometheus-metrics" "-enable-telemetry-reporting"]
I0306 19:41:10.333766       1 main.go:265] Kubernetes version: 1.29.2
I0306 19:41:10.354945       1 main.go:410] Using nginx version: nginx/1.25.3 (nginx-plus-r31-p1)

...

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner March 6, 2024 19:44
@github-actions github-actions bot added chore Pull requests for routine tasks dependencies Pull requests that update a dependency file labels Mar 6, 2024
@jjngx jjngx added this to the v3.5.0 milestone Mar 6, 2024
@shaun-nx shaun-nx mentioned this pull request Mar 7, 2024
Merged
6 tasks
@pdabelf5 pdabelf5 merged commit b97a830 into main Mar 7, 2024
@pdabelf5 pdabelf5 deleted the chore/go-version-bump branch March 7, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

+2 more reviewers

@oseoin oseoin oseoin approved these changes

@shaun-nx shaun-nx shaun-nx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
chore Pull requests for routine tasks dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jjngx @oseoin @vepatel @shaun-nx @pdabelf5
0