10000 Fix/version2 template test by AlexFenlon · Pull Request #5201 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]

Skip to content

Conversation

AlexFenlon
Copy link
Contributor
@AlexFenlon AlexFenlon commented Mar 5, 2024

Proposed changes

Fixes version1/templates_test.go for changes made in #5199

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • [] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@AlexFenlon AlexFenlon requested a review from a team as a code owner March 5, 2024 16:08
@github-actions github-actions bot added the bug An issue reporting a potential bug label Mar 5, 2024
@AlexFenlon AlexFenlon self-assigned this Mar 5, 2024
Copy link
Contributor
@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@AlexFenlon AlexFenlon merged commit d69b1ab into main Mar 6, 2024
@AlexFenlon AlexFenlon deleted the fix/version2-template-test branch March 6, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0