8000 Update collector to use common data types from telemetry-exporter by shaun-nx · Pull Request #5198 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Update collector to use common data types from telemetry-exporter #5198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Mar 8, 2024
Merged

Update collector to use common data types from telemetry-exporter #5198

merged 15 commits into from
Mar 8, 2024

Conversation

shaun-nx
Copy link
Contributor
@shaun-nx shaun-nx commented Mar 5, 2024 •
edited
Loa 10BC0 ding

Proposed changes

This PR integrates the common Data structure defined in nginx/telemetry-exporter#27 to allow NIC to generate its Schema.

This PR also adds two go generate annotations to the Data and NICResourceCounts structs to generate the required Attributes function. This ensures the data is of type Exportable

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Mar 5, 2024
shaun-nx
shaun-nx commented Mar 5, 2024
View reviewed changes
shaun-nx
shaun-nx commented Mar 5, 2024
View reviewed changes
@shaun-nx shaun-nx changed the title Telemetry/schema Update collector to use common data types from telemetry-exporter Mar 5, 2024
@github-actions github-actions bot removed the dependencies Pull requests that update a dependency file label Mar 8, 2024
@shaun-nx shaun-nx requested a review from danielnginx March 8, 2024 10:48
@shaun-nx shaun-nx marked this pull request as ready for review March 8, 2024 11:06
@shaun-nx shaun-nx requested a review from a team as a code owner March 8, 2024 11:06
jjngx
jjngx AAAF approved these changes Mar 8, 2024
View reviewed changes
@shaun-nx shaun-nx merged commit f9d049e into main Mar 8, 2024
@shaun-nx shaun-nx deleted the telemetry/schema branch March 8, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

@danielnginx danielnginx Awaiting requested review from danielnginx

+1 more reviewer

@jjngx jjngx jjngx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shaun-nx @vepatel @jjngx @danielnginx
0