Add NodeCount to telemetry data #5147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j1m-ryan
approved these changes
Feb 21, 2024
vepatel
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds the k8s node counting functionality for the telemetry data collector.
Log example after deployment to a local kind cluster with one node:
I0221 17:08:04.753632 1 collector.go:81] Collecting telemetry data I0221 17:08:04.779743 1 collector.go:91] Exported telemetry data: {ProjectMeta:{Name: Version:} NICResourceCounts:{VirtualServers:0 VirtualServerRoutes:0 TransportServers:0} NodeCount:1}Log example after deployment to a local kind cluster with three nodes:
I0221 17:15:05.111857 1 collector.go:81] Collecting telemetry data I0221 17:15:05.130732 1 collector.go:91] Exported telemetry data: {ProjectMeta:{Name: Version:} NICResourceCounts:{VirtualServers:0 VirtualServerRoutes:0 TransportServers:0} NodeCount:3}Checklist
Before creating a PR, run through this checklist and mark each as complete.