8000 Re-align configurations in helm docs by shaun-nx · Pull Request #4790 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Re-align configurations in helm docs #4790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 13, 2023
Merged

Re-align configurations in helm docs #4790

merged 6 commits into from
Dec 13, 2023

Conversation

shaun-nx
Copy link
Contributor
@shaun-nx shaun-nx commented Dec 13, 2023 •
edited
Loading

Proposed changes

Adds the below list of helm arguments to the Installation with Helm docs:

  • controller.autoscaling.behavior
  • controller.defaultHTTPListenerPort
  • controller.defaultHTTPSListenerPort
  • controller.ingressClass.setAsDefaultIngress
  • controller.initContainerResources

Removes the below helm argument from the installation with Helm docs:

  • controller.enablePreviewPolicies
  • controller.setAsDefaultIngress

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@shaun-nx shaun-nx requested review from a team as code owners December 13, 2023 11:08
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Dec 13, 2023
vepatel
vepatel reviewed Dec 13, 2023
View reviewed changes
@vepatel vepatel requested a review from haywoodsh December 13, 2023 11:12
@codecov Codecov
Copy link
codecov bot commented Dec 13, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (098ffef) 52.01% compared to head (fd5f6b5) 52.04%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4790      +/-   ##
==========================================
+ Coverage   52.01%   52.04%   +0.03%     
==========================================
  Files          60       60              
  Lines       17313    17313              
==========================================
+ Hits         9005     9011       +6     
+ Misses       7995     7991       -4     
+ Partials      313      311       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ADubhlaoich
ADubhlaoich approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor
@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on docs side, I've left an inline suggestion to match @vepatel 's feedback.

@shaun-nx shaun-nx requested a review from vepatel December 13, 2023 11:19
@github-actions github-actions bot added the helm_chart Pull requests that update the Helm Chart label Dec 13, 2023
@shaun-nx shaun-nx merged commit dd2c994 into main Dec 13, 2023
@shaun-nx shaun-nx deleted the docs/helm-arguments branch December 13, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@haywoodsh haywoodsh haywoodsh approved these changes

@vepatel vepatel vepatel approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

+3 more reviewers

@oseoin oseoin oseoin approved these changes

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@jjngx jjngx jjngx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@shaun-nx @ADubhlaoich @haywoodsh @oseoin @j1m-ryan @vepatel @jjngx @pdabelf5
0