8000 add AppProtect version to pod label by pdabelf5 · Pull Request #4759 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]

Skip to content

Conversation

pdabelf5
Copy link
Collaborator
@pdabelf5 pdabelf5 commented Dec 6, 2023

Proposed changes

Adds the appprotect.f5.com/version label to the nginx-ingress pod when AppProtect is in use

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner December 6, 2023 17:39
@pdabelf5 pdabelf5 self-assigned this Dec 6, 2023
@pdabelf5 pdabelf5 added this to the v3.4.0 milestone Dec 6, 2023
@pdabelf5 pdabelf5 linked an issue Dec 6, 2023 that may be closed by this pull request
Copy link
codecov bot commented Dec 6, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (467eb36) 52.16% compared to head (b607182) 52.12%.

Files Patch % Lines
cmd/nginx-ingress/main.go 0.00% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4759      +/-   ##
==========================================
- Coverage   52.16%   52.12%   -0.05%     
==========================================
  Files          59       59              
  Lines       17083    17098      +15     
==========================================
  Hits         8912     8912              
- Misses       7873     7888      +15     
  Partials      298      298              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jjngx jjngx requested a review from a team December 7, 2023 10:41
Copy link
Contributor
@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@pdabelf5 pdabelf5 force-pushed the app-protect-version branch from 358223f to d06a4fb Compare December 8, 2023 09:19
@pdabelf5 pdabelf5 merged commit e037db0 into main Dec 8, 2023
@pdabelf5 pdabelf5 deleted the app-protect-version branch December 8, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write the build version of NGINX App Protect on startup
4 participants
0