10BC0 Fix additional Helm-related chart versioning drift in documentation by ADubhlaoich · Pull Request #4645 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]

Skip to content

Conversation

ADubhlaoich
Copy link
Contributor
@ADubhlaoich ADubhlaoich commented Nov 14, 2023

Proposed changes

This PR fixes a few instances of Helm versions drifting in the documentation as a result of rebases from the revamp.

It also fixes a very minor formatting issue related to spacing on one of the affected pages.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ADubhlaoich ADubhlaoich requested review from a team as code owners November 14, 2023 17:06
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Nov 14, 2023
Copy link
codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4ca9fea) 51.99% compared to head (a353373) 51.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4645   +/-   ##
=======================================
  Coverage   51.99%   51.99%           
=======================================
  Files          59       59           
  Lines       16960    16960           
=======================================
  Hits         8818     8818           
  Misses       7847     7847           
  Partials      295      295           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0