8000 Graduate TransportServer and GlobalConfiguration to v1 by shaun-nx · Pull Request #4574 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Graduate TransportServer and GlobalConfiguration to v1 #4574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Nov 7, 2023
Merged

Graduate TransportServer and GlobalConfiguration to v1 #4574

merged 13 commits into from
Nov 7, 2023

Conversation

shaun-nx
Copy link
Contributor
@shaun-nx shaun-nx commented Oct 26, 2023 •
edited
Loading

Proposed changes

Resolves: #4251

This change:

  • Updates TransportServer resource from v1alpha1 to v1
  • Updates GlobalConfiguration resource from v1alpha1 to v1

Testing

  • Confirmed v1alpha1 of TransportServer and GlobalConfiguration are not deleted when the new CRD is applied
  • Confirmed that v1alpha1 of TransportServer will operates correctly when new CRD is applied
  • Confirmed that v1 and v1alpha1 of TransportServer and GlobalConfiguration can be deployed side-by-side
  • Confirmed that all relevant configurations for TransportServer will operate correctly. These properties were tested in isolation as they were renamed when being moved from v1alphav1/types.go to v1/types.go :
    • HealthCheck
    • Match (property of HealthCheck)
    • UpstreamParameters
    • Action
    • TLS
  • Confirmed all python tests for TransportServer and GlobalConfiguration pass when deployed as v1alpha1 with using the updated CRD
  • Confirmed all python tests for TransportServer and GlobalConfiguration pass when deployed as v1 AND using the updated CRD

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@shaun-nx shaun-nx requested review from a team as code owners October 26, 2023 11:29
@shaun-nx shaun-nx linked an issue Oct 26, 2023 that may be closed by this pull request
Graduate TransportServer and GlobalConfiguration to v1 #4251
Closed
@github-actions github-actions bot added documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements tests Pull requests that update tests labels Oct 26, 2023
vepatel
vepatel reviewed Oct 26, 2023
View reviewed changes
@codecov
Copy link
codecov bot commented Oct 26, 2023 •
edited
Loading

Codecov Report

Merging #4574 (06509a7) into main (af4b47d) will decrease coverage by 0.03%.
The diff coverage is 70.32%.

@@            Coverage Diff             @@
##             main    #4574      +/-   ##
==========================================
- Coverage   51.99%   51.97%   -0.03%     
==========================================
  Files          59       59              
  Lines       16962    16962              
==========================================
- Hits         8820     8816       -4     
- Misses       7847     7849       +2     
- Partials      295      297       +2
Files Coverage Δ
internal/configs/configurator.go 37.68% <100.00%> (ø)
internal/configs/transportserver.go 97.90% <100.00%> (ø)
internal/k8s/configuration.go 95.76% <100.00%> (-0.34%) ⬇️
...is/configuration/validation/globalconfiguration.go 92.39% <100.00%> (ø)
...g/apis/configuration/validation/transportserver.go 96.21% <100.00%> (ø)
internal/configs/config_params.go 77.77% <0.00%> (ø)
internal/k8s/reference_checkers.go 84.00% <87.50%> (ø)
internal/k8s/task_queue.go 0.00% <0.00%> (ø)
internal/k8s/status.go 34.51% <62.50%> (ø)
internal/k8s/handlers.go 6.49% <0.00%> (ø)
... and 1 more

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

vepatel
vepatel reviewed Oct 26, 2023
View reviewed changes
shaun-nx
shaun-nx commented Oct 26, 2023
View reviewed changes
@shaun-nx shaun-nx changed the title Feat/graduate ts and gc Graduate TransportServer and GlobalConfiguration to v1 Oct 26, 2023
vepatel
vepatel reviewed Nov 1, 2023
View reviewed changes
@shaun-nx shaun-nx requested a review from vepatel November 1, 2023 12:33
jjngx
jjngx approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor
@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

haywoodsh
haywoodsh reviewed Nov 2, 2023
View reviewed changes
@shaun-nx shaun-nx requested a review from haywoodsh November 2, 2023 16:18
@shaun-nx shaun-nx requested a review from danielnginx November 2, 2023 17:44
@shaun-nx shaun-nx merged commit 14673e9 into main Nov 7, 2023
@shaun-nx shaun-nx deleted the feat/graduate-ts-and-gc branch November 7, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haywoodsh haywoodsh haywoodsh approved these changes

@lucacome lucacome Awaiting requested review from lucacome

@vepatel vepatel Awaiting requested review from vepatel

@danielnginx danielnginx Awaiting requested review from danielnginx

+1 more reviewer

@jjngx jjngx jjngx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements tests Pull requests that update tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Graduate TransportServer and GlobalConfiguration to v1
5 participants
@shaun-nx @haywoodsh @vepatel @jjngx @danielnginx
0