8000 Add process namespace sharing for ingress controller by panzouh · Pull Request #4559 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Add process namespace sharing for ingress controller #4559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 15, 2023
Merged

Add process namespace sharing for ingress controller #4559

merged 4 commits into from
Nov 15, 2023

Conversation

panzouh
Copy link
Contributor
@panzouh panzouh commented Oct 24, 2023

Proposed changes

The changes allow to configure process namespace sharing for a pod.

Solves : #4558

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@panzouh panzouh requested a review from a team as a code owner October 24, 2023 09:42
@github-actions github-actions bot added the helm_chart Pull requests that update the Helm Chart label Oct 24, 2023
lucacome
lucacome reviewed Oct 25, 2023
View reviewed changes
@codecov
Copy link
codecov bot commented Oct 25, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dbc0ece) 51.96% compared to head (9d05fdd) 51.99%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4559      +/-   ##
==========================================
+ Coverage   51.96%   51.99%   +0.02%     
==========================================
  Files          59       59              
  Lines       16960    16960              
==========================================
+ Hits         8814     8818       +4     
+ Misses       7849     7847       -2     
+ Partials      297      295       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shaun-nx
Copy link
Contributor

@panzouh there are a few things missing from this PR.

  1. Docs will need to be updated for this new value. You can add a new entry for this in charts/nginx-ingress/README.md. This is to ensure we provide a breakdown of what the setting does.
  2. The values.json.schema file in charts/nginx-ingress/ will need to be updated as well.

@panzouh
Copy link
Contributor Author
panzouh commented Oct 26, 2023 •
edited
Loading

@panzouh there are a few things missing from this PR.

  1. Docs will need to be updated for this new value. You can add a new entry for this in charts/nginx-ingress/README.md. This is to ensure we provide a breakdown of what the setting does.
  2. The values.json.schema file in charts/nginx-ingress/ will need to be updated as well.

Of course, given the fact that these modifications are not described in the contribute guide nor in the precommit config meaning that i should do it manually right ?

If it is indeed the case updated it on 76074a2b3d98332f7b9ca30304097cd6e8175445

@github-actions github-actions bot added dependencies Pull requests that update a dependency file documentation Pull requests/issues for documentation labels Oct 26, 2023
lucacome
lucacome approved these changes Oct 26, 2023
View reviewed changes
Copy link
@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panzouh LGTM, but seems like you need to rebase your branch.

@panzouh panzouh force-pushed the main branch 2 times, most recently from 455c52c to 6e08859 Compare October 26, 2023 17:58
@github-actions github-actions bot removed the dependencies Pull requests that update a dependency file label Oct 26, 2023
@panzouh panzouh force-pushed the main branch 2 times, most recently from 6d12d85 to 4f11955 Compare November 2, 2023 14:28
@shaun-nx
Copy link
Contributor
shaun-nx commented Nov 14, 2023 •
edited
Loading

HI @panzouh was having some problems with the pipeline. I'm re-running the failed jobs now.

@shaun-nx shaun-nx self-assigned this Nov 15, 2023
@shaun-nx shaun-nx merged commit 4ca9fea into nginx:main Nov 15, 2023
@shaun-nx
Copy link
Contributor

Thanks for adding this @panzouh ! Keep us informed on #4558 is this setting helps you!
8000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@lucacome lucacome lucacome approved these changes

@shaun-nx shaun-nx shaun-nx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@shaun-nx shaun-nx

Labels
documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@panzouh @shaun-nx @lucacome
0