8000 update documentation for -ingress-class by vepatel · Pull Request #4542 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

update documentation for -ingress-class #4542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 19, 2023
Merged

update documentation for -ingress-class #4542

merged 7 commits into from
Oct 19, 2023

Conversation

vepatel
Copy link
Contributor
@vepatel vepatel commented Oct 19, 2023 •
edited
Loading

Proposed changes

  • Add more clarification around -ingress-class argument

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested review from a team as code owners October 19, 2023 10:33
@vepatel vepatel linked an issue Oct 19, 2023 that may be closed by this pull request
Clarification needed in ingressClass argument description #4531
Closed
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Oct 19, 2023
@codecov
Copy link
codecov bot commented Oct 19, 2023 •
edited
Loading

Codecov Report

Merging #4542 (ba334c2) into main (728a2f6) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4542      +/-   ##
==========================================
- Coverage   51.98%   51.96%   -0.03%     
==========================================
  Files          59       59              
  Lines       16965    16965              
==========================================
- Hits         8820     8816       -4     
- Misses       7850     7852       +2     
- Partials      295      297       +2

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vepatel vepatel merged commit 093f92d into main Oct 19, 2023
@vepatel vepatel deleted the docs/fix-ingressclass-cli branch October 19, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JTorreG JTorreG JTorreG approved these changes

@ADubhlaoich ADubhlaoich Awaiting requested review from ADubhlaoich

+2 more reviewers

@jjngx jjngx jjngx approved these changes

@shaun-nx shaun-nx shaun-nx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarification needed in ingressClass argument description
4 participants
@vepatel @JTorreG @jjngx @shaun-nx
0