Simplify release script #4425
Merged
Simplify release script #4425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacome
commented
Sep 26, 2023
hack/changelog-template.txt
Outdated
Comment on lines
+27
to
+31
There was a problem hiding this comment.
I don't think adding this to every minor release adds much value. Should we just add a link to https://docs.nginx.com/nginx-ingress-controller/technical-specifications/#supported-kubernetes-versions at the top of the page? @brianehlert @ADubhlaoich @Jcahilltorre
Codecov Report
@@ Coverage Diff @@
## main #4425 +/- ##
==========================================
- Coverage 52.12% 52.08% -0.04%
==========================================
Files 59 59
Lines 16956 16956
==========================================
- Hits 8838 8832 -6
- Misses 7821 7825 +4
- Partials 297 299 +2 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
53325e3 to
a223cbb
Compare
vepatel
approved these changes
Sep 27, 2023
shaun-nx
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
There's a single release script that can now be used for any kind of release.