8000 Expose Prometheus metrics through a headless Service. by shaun-nx · Pull Request #4331 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Expose Prometheus metrics through a headless Service. #4331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Sep 12, 2023
Merged

Expose Prometheus metrics through a headless Service. #4331

merged 13 commits into from
Sep 12, 2023

Conversation

shaun-nx
Copy link
Contributor
@shaun-nx shaun-nx commented Sep 6, 2023 •
edited
Loading

Proposed changes

Relates to: #4210

This change :

  • Updates our helm values.yaml to allow users to create an independent Headless service that exposes prometheus metrics on port 9113. This enables to users to expose prometheus metrics internally without needing for forward the metrics directly from the Ingress Controller.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@shaun-nx shaun-nx requested a review from a team as a code owner September 6, 2023 15:56
@github-actions github-actions bot added enhancement Pull requests for new features/feature enhancements helm_chart Pull requests that update the Helm Chart labels Sep 6, 2023
@shaun-nx shaun-nx changed the title Feat/prometheus servicemonitor Create ClusterIP Service for Prometheus to expose metrics internally Sep 6, 2023
@codecov
Copy link
codecov bot commented Sep 7, 2023 •
edited
Loading

Codecov Report

Merging #4331 (59bcb2b) into main (5b1d085) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4331   +/-   ##
=======================================
  Coverage   52.17%   52.17%           
=======================================
  Files          59       59           
  Lines       16929    16929           
=======================================
  Hits         8832     8832           
  Misses       7798     7798           
  Partials      299      299

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shaun-nx shaun-nx changed the title Create ClusterIP Service for Prometheus to expose metrics internally Expose Prometheus metrics through a headless Service. Sep 8, 2023
@vepatel vepatel linked an issue Sep 11, 2023 that may be closed by this pull request
Add prometheus servicemonitor support for NGINX Ingress controller #4210
Closed
jasonwilliams14
jasonwilliams14 approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor
@jasonwilliams14 jasonwilliams14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shaun-nx shaun-nx merged commit a843e0c into main Sep 12, 2023
@shaun-nx shaun-nx deleted the feat/prometheus-servicemonitor branch September 12, 2023 14:53
@lucacome lucacome removed the enhancement Pull requests for new features/feature enhancements label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

@haywoodsh haywoodsh Awaiting requested review from haywoodsh

+1 more reviewer

@jasonwilliams14 jasonwilliams14 jasonwilliams14 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
helm_chart Pull requests that update the Helm Chart
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add prometheus servicemonitor support for NGINX Ingress controller
4 participants
@shaun-nx @jasonwilliams14 @vepatel @lucacome
0