8000 Add path-regex annotation for ingress by jjngx · Pull Request #4127 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Add path-regex annotation for ingress #4127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jul 26, 2023
Merged

Add path-regex annotation for ingress #4127

merged 17 commits into from
Jul 26, 2023

Conversation

jjngx
Copy link
Contributor
@jjngx jjngx commented Jul 20, 2023 •
edited
Loading

Proposed changes

This PR adds support for path-regex annotation for Ingress.
Users can define paths (locations) using one of the following regex annotations:

nginx.org/path-regex: "case_sensitive"
nginx.org/path-regex: "case_insensitive"
nginx.org/path-regex: "exact"

Example ingress resource:

apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: cafe-ingress
  annotations:
    nginx.org/path-regex: "case_sensitive"
spec:
  ingressClassName: nginx
...

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the enhancement Pull requests for new features/feature enhancements label Jul 20, 2023
@github-actions
Copy link
Contributor
github-actions bot commented Jul 20, 2023 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@jjngx jjngx self-assigned this Jul 20, 2023
@codecov
Copy link
codecov bot commented Jul 20, 2023 •
edited
Loading

Codecov Report

Merging #4127 (92a4fa6) into main (0a02259) will increase coverage by 0.06%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main    #4127      +/-   ##
==========================================
+ Coverage   51.84%   51.91%   +0.06%     
==========================================
  Files          59       59              
  Lines       16710    16735      +25     
==========================================
+ Hits         8664     8688      +24     
- Misses       7747     7749       +2     
+ Partials      299      298       -1
Files Changed Coverage Δ
internal/configs/annotations.go 23.60% <0.00%> (-0.40%) ⬇️
internal/configs/version1/template_helper.go 100.00% <100.00%> (ø)
internal/k8s/validation.go 93.56% <100.00%> (+0.08%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Jul 20, 2023
@jjngx jjngx marked this pull request as ready for review July 20, 2023 13:07
@jjngx jjngx requested a review from a team as a code owner July 20, 2023 13:07
@jjngx jjngx mentioned this pull request Jul 20, 2023
Closed
@jjngx jjngx linked an issue Jul 20, 2023 that may be closed by this pull request
Support regex path for Ingress resource #4089
Closed
@jjngx jjngx requested a review from jasonwilliams14 July 20, 2023 13:37
shaun-nx
shaun-nx reviewed Jul 24, 2023
View reviewed changes
jjngx and others added 2 commits July 24, 2023 11:00
@jjngx @shaun-nx
Update docs/content/configuration/ingress-resources/advanced-configur…
87b88cb 
…ation-with-annotations.md

Co-authored-by: Shaun <s.odonovan@f5.com>
Signed-off-by: Jakub Jarosz <99677300+jjngx@users.noreply.github.com>
@jjngx @shaun-nx
Update examples/ingress-resources/path-regex/README.md
f1e7293 
Co-authored-by: Shaun <s.odonovan@f5.com>
Signed-off-by: Jakub Jarosz <99677300+jjngx@users.noreply.github.com>
jasonwilliams14
jasonwilliams14 reviewed Jul 24, 2023
View reviewed changes
Copy link
Contributor
@jasonwilliams14 jasonwilliams14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few ideas/questions for review.

shaun-nx
shaun-nx approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor
@shaun-nx shaun-nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jjngx jjngx merged commit eef59d2 into main Jul 26, 2023
@jjngx jjngx deleted the feat/regex-ingress-resource branch July 26, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianehlert brianehlert brianehlert left review comments

@haywoodsh haywoodsh haywoodsh approved these changes

@vepatel vepatel vepatel approved these changes

@ADubhlaoich ADubhlaoich Awaiting requested review from ADubhlaoich

+2 more reviewers

@jasonwilliams14 jasonwilliams14 jasonwilliams14 left review comments

@shaun-nx shaun-nx shaun-nx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jjngx jjngx

Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support regex path for Ingress resource
6 participants
@jjngx @brianehlert @haywoodsh @jasonwilliams14 @vepatel @shaun-nx
0