Add clusterIP to service if specified in values #4058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: EutiziStefano <57256061+EutiziStefano@users.noreply.github.com>
Signed-off-by: EutiziStefano <57256061+EutiziStefano@users.noreply.github.com>
Signed-off-by: EutiziStefano <57256061+EutiziStefano@users.noreply.github.com>
lucacome
reviewed
Jul 21, 2023
|
@EutiziStefano would you like to make the suggested change? |
Signed-off-by: Luca Comellini <luca.com@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #4058 +/- ##
==========================================
- Coverage 51.97% 51.95% -0.03%
==========================================
Files 59 59
Lines 16762 16762
==========================================
- Hits 8712 8708 -4
- Misses 7753 7755 +2
- Partials 297 299 +2 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lucacome
reviewed
Aug 15, 2023
Signed-off-by: Luca Comellini <luca.com@gmail.com>
lucacome
approved these changes
Aug 15, 2023
|
Thanks @lucacome |
vepatel
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
If you need to specify a fixed clusterip, add it to the values and it will be used in the service manifest.
Opened issue: #4057
Checklist
Before creating a PR, run through this checklist and mark each as complete.