8000 Read Prometheus key/cert from memory by jjngx · Pull Request #4023 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Read Prometheus key/cert from memory #4023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jun 28, 2023
Merged

Read Prometheus key/cert from memory #4023

merged 15 commits into from
Jun 28, 2023

Conversation

jjngx
Copy link
Contributor
@jjngx jjngx commented Jun 19, 2023

Proposed changes

This PR addresses the following:

  • cert and key files for metrics server are not stored on container's FS (I/O ops is eliminated)
  • tls cert for metrics server is created immediately from prometheus k8s cert when the metrics server starts
  • the mechanism is exactly the same as introduced in the service insight server

Tested manually on a local kind cluster.
Existing Python integration tests cover the functionality.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner June 19, 2023 17:55
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jun 19, 2023
@github-actions
Copy link
Contributor
github-actions bot commented Jun 19, 2023 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@codecov
Copy link
codecov bot commented Jun 19, 2023 •
edited
Loading

Codecov Report

Merging #4023 (7050689) into main (6ce07ed) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 7050689 differs from pull request most recent head b8bf859. Consider uploading reports for the commit b8bf859 to get more accurate results

@@            Coverage Diff             @@
##             main    #4023      +/-   ##
==========================================
+ Coverage   51.83%   51.85%   +0.02%     
==========================================
  Files          59       59              
  Lines       16705    16705              
==========================================
+ Hits         8659     8663       +4     
+ Misses       7747     7745       -2     
+ Partials      299      297       -2

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jjngx jjngx requested review from haywoodsh, vepatel and shaun-nx June 19, 2023 21:10
shaun-nx
shaun-nx reviewed Jun 20, 2023
View reviewed changes
@jjngx jjngx requested review from a team, ciarams87 and pleshakov June 20, 2023 11:50
@jjngx jjngx requested a review from a team June 26, 2023 10:51
@shaun-nx shaun-nx self-requested a review June 28, 2023 09:20
@shaun-nx shaun-nx added the enhancement Pull requests for new features/feature enhancements label Jun 28, 2023
@jjngx jjngx merged commit ff4dea6 into main Jun 28, 2023
@jjngx jjngx deleted the chore/prometheus branch June 28, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haywoodsh haywoodsh haywoodsh approved these changes

@vepatel vepatel Awaiting requested review from vepatel

@ciarams87 ciarams87 Awaiting requested review from ciarams87

@pleshakov pleshakov Awaiting requested review from pleshakov

+1 more reviewer

@shaun-nx shaun-nx shaun-nx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
chore Pull requests for routine tasks enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjngx @haywoodsh @shaun-nx
0