Tutorial for FCP #3954
Merged
Tutorial for FCP #3954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3954 +/- ##
==========================================
- Coverage 51.85% 51.83% -0.03%
==========================================
Files 59 59
Lines 16705 16705
==========================================
- Hits 8663 8659 -4
- Misses 7745 7747 +2
- Partials 297 299 +2 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ADubhlaoich
reviewed
Jun 7, 2023
ADubhlaoich
reviewed
Jun 7, 2023
ADubhlaoich
reviewed
Jun 7, 2023
ADubhlaoich
reviewed
Jun 7, 2023
brianehlert
requested changes
Jun 7, 2023
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Alan Dooley <ADubhlaoich@users.noreply.github.com> Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
Co-authored-by: Alan Dooley <ADubhlaoich@users.noreply.github.com> Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
Co-authored-by: Alan Dooley <ADubhlaoich@users.noreply.github.com> Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
Signed-off-by: Brian Ehlert <b.ehlert@f5.com>
Signed-off-by: Brian Ehlert <b.ehlert@f5.com>
Signed-off-by: Brian Ehlert <b.ehlert@f5.com>
for more information, see https://pre-commit.ci
edited rather than going back and forth Signed-off-by: Brian Ehlert <b.ehlert@f5.com>
for more information, see https://pre-commit.ci
whoops fixes Signed-off-by: Brian Ehlert <b.ehlert@f5.com>
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Files |
brianehlert
approved these changes
Jun 20, 2023
lucacome
reviewed
Jun 20, 2023
examples/shared-examples/usage-reporting/cluster-connector.yaml
Outdated
Show resolved
Hide resolved
lucacome
reviewed
Jun 20, 2023
Co-authored-by: Luca Comellini <luca.com@gmail.com> Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
Co-authored-by: Luca Comellini <luca.com@gmail.com> Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
Co-authored-by: Luca Comellini <luca.com@gmail.com> Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
Co-authored-by: Luca Comellini <luca.com@gmail.com> Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
Co-authored-by: Luca Comellini <luca.com@gmail.com> Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
Co-authored-by: Luca Comellini <luca.com@gmail.com> Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
Co-authored-by: Luca Comellini <luca.com@gmail.com> Signed-off-by: Alan Dooley <ADubhlaoich@users.noreply.github.com>
This commit makes a number of changes to the frontmatter of the page and the phrasing of specific sections for clarity and readability. It also removes the caret character from the shell commands, which should make it easier for the reader to copy & paste from the examples.
ADubhlaoich
reviewed
Jun 21, 2023
ADubhlaoich
approved these changes
Jun 21, 2023
Signed-off-by: Alan Dooley <ADubhlaoich@users.noreply.github.com>
lucacome
reviewed
Jun 22, 2023
Co-authored-by: Luca Comellini <luca.com@gmail.com> Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Tutorial to configure and deploy cluster-connector, and connect to NMS for usage reporting, as well as retrieving usage data from the NMS API.
Checklist
Before creating a PR, run through this checklist and mark each as complete.