8000 fix --enternal-service flag when using serviceNameOverride by timnee · Pull Request #3933 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

fix --enternal-service flag when using serviceNameOverride #3933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 7, 2023
Merged

fix --enternal-service flag when using serviceNameOverride #3933

merged 3 commits into from
Jun 7, 2023

Conversation

timnee
Copy link
Contributor
@timnee timnee commented May 23, 2023

Proposed changes

Add a template helper for nginx-ingress.controller.service.name to fix the --external-service flag on deployement/daemonset. This fixes a bug introduced in PR #3802 which resulted in ingress status to be empty

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@timnee timnee requested a review from a team as a code owner May 23, 2023 18:25
@github-actions github-actions bot added the helm_chart Pull requests that update the Helm Chart label May 23, 2023
@timnee timnee force-pushed the helm-controler-service-name branch from 8bae744 to 2af2a6d Compare May 23, 2023 18:36
@brianehlert brianehlert added the bug An issue reporting a potential bug label Jun 5, 2023
@tomasohaodha tomasohaodha requested review from vepatel and ciarams87 June 6, 2023 08:56
@codecov
Copy link
codecov bot commented Jun 6, 2023 •
edited
Loading

Codecov Report

Merging #3933 (482a602) into main (268b00b) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 482a602 differs from pull request most recent head 942a5f2. Consider uploading reports for the commit 942a5f2 to get more accurate results

@@            Coverage Diff             @@
##             main    #3933      +/-   ##
==========================================
- Coverage   51.81%   51.79%   -0.02%     
==========================================
  Files          59       59              
  Lines       16697    16697              
==========================================
- Hits         8651     8648       -3     
- Misses       7747     7749       +2     
- Partials      299      300       +1

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

vepatel
vepatel approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor
@vepatel vepatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified

@github-actions github-actions bot removed the bug An issue reporting a potential bug label Jun 7, 2023
@ciarams87 ciarams87 merged commit 47f34dc into nginx:main Jun 7, 2023
@ciarams87 ciarams87 added the bug An issue reporting a potential bug label Jun 7, 2023
@brianehlert brianehlert mentioned this pull request Jun 20, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haywoodsh haywoodsh haywoodsh approved these changes

@ciarams87 ciarams87 ciarams87 approved these changes

@vepatel vepatel vepatel approved these changes

Assignees
No one assigned
Labels
bug An issue reporting a potential bug helm_chart Pull requests that update the Helm Chart
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@timnee @haywoodsh @ciarams87 @vepatel @brianehlert
0