10BC0 Reverse order of NAPDOS maxDaemons and maxWorkers in Helm chart by ciarams87 · Pull Request #3905 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Reverse order of NAPDOS maxDaemons and maxWorkers in Helm chart #3905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2023
Merged

Reverse order of NAPDOS maxDaemons and maxWorkers in Helm chart #3905

merged 1 commit into from
May 22, 2023

Conversation

ciarams87
Copy link
Contributor

Proposed changes

The values of -app-protect-dos-max-daemons and -app-protect-dos-max-workers were reversed in the Helm chart templates - this commit rectifies the issue.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork
8000

@ciarams87 ciarams87 requested a review from a team as a code owner May 17, 2023 08:40
@github-actions github-actions bot added the helm_chart Pull requests that update the Helm Chart label May 17, 2023
@codecov
Copy link
codecov bot commented May 17, 2023 •
edited
Loading

Codecov Report

Merging #3905 (b7386bb) into main (9654b28) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3905   +/-   ##
=======================================
  Coverage   51.79%   51.79%           
=======================================
  Files          59       59           
  Lines       16697    16697           
=======================================
  Hits         8648     8648           
  Misses       7749     7749           
  Partials      300      300

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

lucacome
lucacome approved these changes May 17, 2023
View reviewed changes
Copy link
@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐛

@ciarams87 ciarams87 merged commit fe21773 into main May 22, 2023
@ciarams87 ciarams87 deleted the fix-helm-ap branch May 22, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@lucacome lucacome lucacome approved these changes

@jjngx jjngx jjngx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
helm_chart Pull requests that update the Helm Chart
4630 Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ciarams87 @lucacome @jjngx
0