8000 Fix gunzip support for VS and add python tests by jjngx · Pull Request #3844 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Fix gunzip support for VS and add python tests #3844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 4, 2023
Merged

Fix gunzip support for VS and add python tests #3844

merged 6 commits into from
May 4, 2023

Conversation

jjngx
Copy link
Contributor
@jjngx jjngx commented May 3, 2023 •
edited
Loading

Proposed changes

This PR:

  • fixes gunzip support for VS (gunzip is of type bool instead of string)
  • updates NIC documentation
  • updates examples (custom-resources/jwt)
  • adds Python integration tests

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner May 3, 2023 16:58
@github-actions github-actions bot added documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements helm_chart Pull requests that update the Helm Chart tests Pull requests that update tests labels May 3, 2023
@codecov
Copy link
codecov bot commented May 3, 2023 •
edited
Loading

Codecov Report

Merging #3844 (6e8ccdf) into main (a79415e) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3844      +/-   ##
==========================================
- Coverage   52.39%   52.37%   -0.02%     
==========================================
  Files          59       59              
  Lines       16931    16925       -6     
==========================================
- Hits         8871     8865       -6     
  Misses       7761     7761              
  Partials      299      299
Impacted Files Coverage Δ
internal/configs/version2/http.go 0.00% <ø> (ø)
pkg/apis/configuration/validation/virtualserver.go 94.39% <ø> (-0.04%) ⬇️
internal/configs/virtualserver.go 94.55% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

vepatel
vepatel reviewed May 4, 2023
View reviewed changes
haywoodsh
haywoodsh reviewed May 4, 2023
View reviewed changes
@jjngx jjngx merged commit fab521e into main May 4, 2023
@jjngx jjngx deleted the feat/gunzip-virtualserver branch May 4, 2023 17:28
@shaun-nx shaun-nx added this to the v3.2.0 milestone Jun 20, 2023
@lucacome lucacome added bug An issue reporting a potential bug and removed enhancement Pull requests for new features/feature enhancements labels Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel left review comments

@haywoodsh haywoodsh haywoodsh approved these changes

@ciarams87 ciarams87 ciarams87 approved these changes

@jasonwilliams14 jasonwilliams14 Awaiting requested review from jasonwilliams14

@shaun-nx shaun-nx Awaiting requested review from shaun-nx

Assignees
No one assigned
Labels
bug An issue reporting a potential bug documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart tests Pull requests that update tests
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
6 participants
@jjngx @haywoodsh @ciarams87 @vepatel @lucacome @shaun-nx
0