Remove semverCompare for allocateLoadBalancerNodePorts #3814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubernetes 1.22.0 is now a minimum requirement for the entire chart.
Codecov Report
@@ Coverage Diff @@
## main #3814 +/- ##
==========================================
- Coverage 51.95% 51.91% -0.04%
==========================================
Files 59 59
Lines 16742 16742
==========================================
- Hits 8698 8692 -6
- Misses 7746 7750 +4
- Partials 298 300 +2 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ciarams87
approved these changes
May 17, 2023
jjngx
approved these changes
May 17, 2023
lucacome
reviewed
May 18, 2023
lucacome
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubernetes 1.22.0 is now a minimum requirement for the entire chart.
Proposed changes
Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue here in this description (not in the title of the PR).
Checklist
Before creating a PR, run through this checklist and mark each as complete.